fix: write rule name into markdown frontmatter - #13150
Open
tonycoder-hub wants to merge 1 commit into
Open
Conversation
createRuleMarkdown accepted a name argument but never emitted it. The name used to be rendered as an H1 in the rule body and was dropped when the body was simplified, so rules created via create_rule_block or the "New Rule" workspace block had no name and fell back to their file path.
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createRuleMarkdown takes a name argument and never emits it. The name used to be an H1 in the rule body and was dropped without adding it to YAML frontmatter, so rules created via create_rule_block or New Rule had no name and markdownToRule fell back to the file path.
Frontmatter now includes name: name.trim(), matching createPromptMarkdown.
Tests: packages/config-yaml markdown jest 144 passed; core tools/config/markdown 15 passed; workspaceBlocks vitest 10 passed. Distinct from #13140-#13149.